feat: psp22 standard for decrease_allowance and burn pallet methods
#322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chungquantin
changed the base branch from
main
to
chungquantin/main-psp22_pallet
chungquantin
commented
Oct 2, 2024
chungquantin
changed the base branch from
chungquantin/main-psp22_pallet
to
main
chungquantin
requested review from
Daanvdplas and
evilrobot-01
and removed request for
Daanvdplas
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #322 +/- ##
==========================================
+ Coverage 51.47% 51.57% +0.10%
==========================================
Files 48 48
Lines 4894 4907 +13
Branches 4894 4907 +13
==========================================
+ Hits 2519 2531 +12
- Misses 2326 2327 +1
Partials 49 49
|
evilrobot-01
approved these changes
Oct 2, 2024
Daanvdplas
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussion: #300 (comment)
decrease_allowance:Fungibles::decrease_allowance()saturating_sub the value, it shouldchecked_suband throw an error instead. Hence, we don't have to handleInsufficientAllowanceon the contract side.burn:InsufficientBalancecase is not returned in theburnpallet api if thevalueexceeds the minted value. Indecrease_balancemethod ofpallet-assets, it is alsosaturating_sub.NOTE: Original PR #311 includes file permission changes which is hard to revert and makes the commit history unclean. Hence, I created this PR to substitute the original on and move all comments / resolve comments left by reviewers.